Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative path for bundle labels in bundle analysis #7737

Merged
merged 5 commits into from Mar 20, 2022
Merged

Use relative path for bundle labels in bundle analysis #7737

merged 5 commits into from Mar 20, 2022

Conversation

ittaibaratz
Copy link
Contributor

There is no value in providing the full path as the bundle label, and it can get quite long in CI/CD

Changing to relativePath will make the label shorter and easier to read

↪️ Pull Request

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@ittaibaratz
Use relative path for bundle labels
c88f572 
There is no value in providing the full path as the bundle label, and it can get quite long in CI/CD

Changing to relativePath will make the label shorter and easier to read
@height
Copy link

height bot commented Feb 18, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

ittaibaratz and others added 2 commits February 28, 2022 18:51
@ittaibaratz @mischnic
Update packages/reporters/bundle-analyzer/src/BundleAnalyzerReporter.js
cda09a3 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
@ittaibaratz
Merge branch 'v2' into patch-1
20e83e8
@ittaibaratz
Copy link
Contributor Author

ittaibaratz commented Mar 1, 2022 •
edited

@mischnic I would also like to enable bundle analysis on the modules only: (Right now it has both module and no-module, so everything is replicated)

image

Any quick pointers for how I would make it happen? Thanks!

i.e. where can I place the config for that behavior assuming that not everyone wants it.

cc @devongovett

@ittaibaratz ittaibaratz marked this pull request as ready for review March 1, 2022 21:14
@mischnic
Copy link
Member

I guess the hard part for that is determining which bundle is the nomodule half of a nomodule/module pair.
And a config that only lists module bundles in the report could incorrectly filter out non-module worker bundles...

mischnic
mischnic approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem I can see with this change is projects including files from outside the project path, then you'd get paths like ../../foo. But this situation isn't really supported anyway because these files aren not watched anyway

@devongovett devongovett merged commit 957523f into parcel-bundler:v2 Mar 20, 2022
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge v2 into lettertwo/v2-2022-03-24
2b39275 
* upstream/v2:
  Upgrade Flow to 0.174.1 (#7849)
  v2.4.0
  v2.4.0 changelog
  Bump Parcel CSS
  Dynamic imports priority fix closes #6980 (#7061)
  fix(transformers): errors.map is not a function (#7672)
  Make NodeResolver check realpath before resolving with `source` entry (#7846)
  docs: fix wrong location documents (#7689)
  Fix: escape double quote of url value in CSS `url()` (#7718)
  Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845)
  Use relative path for bundle labels in bundle analysis (#7737)
  Allow use react-jsx transform in React 16.14.0 (#7728)
  Move to @parcel/css by default (#7821)
  Feature: pick PORT number also from .env file (#7819)
  Enable parsing static initialization blocks (#7839)
  Bump swc and prevent pure comment removal (#7833)
  Bump swc (#7777)
  Human readable file size in bundle analyzer report (#7766)
  Improve emoji support detection (#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ittaibaratz @mischnic @devongovett