Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc #7777

Merged
merged 12 commits into from Mar 12, 2022
Merged

Bump swc #7777

merged 12 commits into from Mar 12, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Mar 1, 2022

Closes #7551

  1. There is no ExprOrSuper anymore, there's a Callee enum instead now
  2. import() and import.meta.* now have specialized Callee::Import and Expr::MemberProp variants, no more id == "import"
  3. MemberExpr now contains an expression and a MemberProp enum which differentiates between computed, identifier and private class property.
  4. Import and export declarations now support both strings and literals as identifiers because this has been standardized: import { "foo bar" as foo} from "xyz";

Notably, I needed to bump the swc helpers dependency because new helpers were added in the meantime. If you upgrade Parcel without doing this, code using private class properties might break

@height
Copy link

height bot commented Mar 1, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Mar 1, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.25s -296.00ms
Cached 517.00ms +18.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 485.39kb +307.00b ⚠️ 5.46s -61.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 485.39kb +307.00b ⚠️ 5.52s +38.00ms

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.15m +14.00ms
Cached 1.67s +118.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.8c69068b.js 1.77mb -16.00b 🚀 19.50s -91.00ms
dist/index.b75d1013.js 693.02kb +330.00b ⚠️ 51.65s +78.00ms
dist/editorView.5940e8e4.js 594.77kb +0.00b 51.57s +13.50s ⚠️
dist/popup.8620ff0b.js 209.53kb +1.00b ⚠️ 51.57s +13.50s ⚠️
dist/EmojiPickerComponent.de4cd443.js 147.13kb +0.00b 21.09s -10.94s 🚀
dist/Toolbar.b2284ccb.js 107.23kb +23.00b ⚠️ 51.57s +13.50s ⚠️
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 51.57s +13.50s ⚠️
dist/esm.b1e8a23b.js 33.15kb +0.00b 21.09s -10.94s 🚀
dist/DatePicker.ad00f88a.js 22.98kb +0.00b 21.09s -10.94s 🚀
dist/js.59c58b0d.js 17.25kb +0.00b 38.19s -12.84s 🚀
dist/ui.39c61c40.js 14.94kb +0.00b 51.57s +13.50s ⚠️
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 51.57s +13.50s ⚠️
dist/dropzone.0d17e26c.js 12.16kb +0.00b 51.57s +13.50s ⚠️
dist/media-viewer.e019af9e.js 4.36kb +1.00b ⚠️ 38.19s +130.00ms
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 51.57s +13.50s ⚠️
dist/png-chunks-extract.f2395929.js 3.47kb +0.00b 38.19s -12.84s 🚀
dist/dropzone.d03df26a.js 3.29kb +0.00b 51.57s +13.50s ⚠️
dist/clipboard.7ceac12b.js 2.93kb +0.00b 51.57s +13.50s ⚠️
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 51.57s +13.50s ⚠️
dist/feedback.86e2830a.js 1.77kb +0.00b 21.09s -10.94s 🚀
dist/browser.d28fd36c.js 1.69kb +0.00b 51.57s +13.50s ⚠️
dist/workerHasher.79d92bfb.js 1.63kb +0.00b 21.09s -10.94s 🚀
dist/heading6.d11e359e.js 1.51kb +0.00b 21.09s -10.94s 🚀
dist/heading5.eb24367d.js 1.38kb +0.00b 21.09s -10.94s 🚀
dist/expand.e34b4ec7.js 1.29kb +0.00b 21.09s -10.94s 🚀
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 51.57s +13.50s ⚠️
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 51.57s +13.50s ⚠️
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 51.57s +13.50s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.f18f6b83.js 1.77mb -16.00b 🚀 19.40s -217.00ms
dist/index.b75d1013.js 693.02kb +330.00b ⚠️ 52.14s +255.00ms
dist/popup.8620ff0b.js 209.53kb +1.00b ⚠️ 38.20s -11.00ms
dist/Toolbar.b2284ccb.js 107.23kb +23.00b ⚠️ 38.20s -13.00ms
dist/media-viewer.e019af9e.js 4.36kb +1.00b ⚠️ 38.20s -11.00ms

Three.js ✅

Timings

Description Time Difference
Cold 7.43s -45.00ms
Cached 312.00ms +7.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +1.00b ⚠️ 5.30s -83.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +1.00b ⚠️ 5.44s +8.00ms

Click here to view a detailed benchmark overview.

@mischnic mischnic marked this pull request as ready for review March 1, 2022 18:15
@mischnic
Copy link
Member Author

mischnic commented Mar 12, 2022

This also improves the size of the binary (macos, x64) from 19.7mb to 17.5mb

@mischnic mischnic merged commit e294eaf into v2 Mar 12, 2022
@mischnic mischnic deleted the bump-swc branch March 12, 2022 19:27
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  Upgrade Flow to 0.174.1 (#7849)
  v2.4.0
  v2.4.0 changelog
  Bump Parcel CSS
  Dynamic imports priority fix closes #6980 (#7061)
  fix(transformers): errors.map is not a function (#7672)
  Make NodeResolver check realpath before resolving with `source` entry (#7846)
  docs: fix wrong location documents (#7689)
  Fix: escape double quote of url value in CSS `url()` (#7718)
  Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845)
  Use relative path for bundle labels in bundle analysis (#7737)
  Allow use react-jsx transform in React 16.14.0 (#7728)
  Move to @parcel/css by default (#7821)
  Feature: pick PORT number also from .env file (#7819)
  Enable parsing static initialization blocks (#7839)
  Bump swc and prevent pure comment removal (#7833)
  Bump swc (#7777)
  Human readable file size in bundle analyzer report (#7766)
  Improve emoji support detection (#7775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel replaces String constructor, breaks some libraries
3 participants