Feature: pick PORT number also from .env file #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devongovett
approved these changes
Mar 14, 2022
gorakong
pushed a commit
that referenced
this pull request
Nov 3, 2022
* upstream/v2: Upgrade Flow to 0.174.1 (#7849) v2.4.0 v2.4.0 changelog Bump Parcel CSS Dynamic imports priority fix closes #6980 (#7061) fix(transformers): errors.map is not a function (#7672) Make NodeResolver check realpath before resolving with `source` entry (#7846) docs: fix wrong location documents (#7689) Fix: escape double quote of url value in CSS `url()` (#7718) Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845) Use relative path for bundle labels in bundle analysis (#7737) Allow use react-jsx transform in React 16.14.0 (#7728) Move to @parcel/css by default (#7821) Feature: pick PORT number also from .env file (#7819) Enable parsing static initialization blocks (#7839) Bump swc and prevent pure comment removal (#7833) Bump swc (#7777) Human readable file size in bundle analyzer report (#7766) Improve emoji support detection (#7775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Close: #6130
Hi team 👋
currently, parcel dev-server determines PORT number only with
PORTenvironment variable provided from cli, but PORT environmental variable provided from.envfile is not considered. This PR allows the user to specify PORT number with.envfile.💻 Examples
before
after
with
# .env PORT=3456🚨 Test instructions
I could not find any test case about PORT behavior, so I did not write a test. If I should add a test, please point out.
✔️ PR Todo
Added/updated unit tests for this changeI could not find any test case about PORT behavior, so I did not write a test. If I should add a test, please point out.