Respect Babel's addExternalDependency #7820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. |
mischnic
force-pushed
the
babel-addExternalDependency
branch
from
010943c
to
02a800d
Compare
mischnic
force-pushed
the
babel-addExternalDependency
branch
from
02a800d
to
c841f43
Compare
devongovett
approved these changes
Jun 19, 2022
|
Actually, it looks like the file path isn't necessarily absolute. Babel CLI's watcher first resolves the each dependency https://github.com/babel/babel/blob/7d63d2f8337065a000d80da3282fba91f10fc6c2/packages/babel-cli/src/babel/watcher.ts#L74-L76
I'm not even sure how Parcel's |
|
Turns out it's not even necessarily a file:
|
mischnic
commented
Jul 5, 2022
| @@ -82,6 +82,11 @@ export default async function babel7( | |||
| remapAstLocations(babelCore.types, res.ast, map); | |||
| } | |||
| } | |||
| if (res.externalDependencies) { | |||
| for (let f of res.externalDependencies) { | |||
| asset.invalidateOnFileChange(f); | |||
There was a problem hiding this comment.
And I guess Babel also doesn't differentiate between onFileChange and onFileCreate, so we'd have to do both (or check if the file exists)
|
What do we want to do with this one? |
|
It's still somehow "undefined behaviour" to pass non-absolute paths (be it relative or "virtual") to EDIT: done |
mischnic
force-pushed
the
babel-addExternalDependency
branch
from
c841f43
to
32e02ef
Compare
mischnic
force-pushed
the
babel-addExternalDependency
branch
from
32e02ef
to
ea6526b
Compare
|
Also, what should we do about #7820 (comment) ? |
mischnic
force-pushed
the
babel-addExternalDependency
branch
from
ea6526b
to
372d431
Compare
devongovett
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
babel/babel#14065
Just forward
api.addExternalDependency(f)toasset.invalidateOnFileChange(f)Currently blocked by Incorrect js file extension with --no-scope-hoist #7813 (comment)