Fix wrapped assets importing their own namespace #7978
Conversation
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
| this.wrappedAssets.has(resolvedAsset.id) | ||
| ) { | ||
| // Directly use module.exports for wrapped assets importing themselves. | ||
| return 'module.exports'; |
There was a problem hiding this comment.
If the asset is wrapped, won't obj already be a parcelRequire?
There was a problem hiding this comment.
For some reason, we have this condition:
which will make
isWrapped itself false in this self-import case.
There was a problem hiding this comment.
hmm I don't remember why...
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
Found as part of #7956
Right now, I've made it just replace
$x$import$yby "module.exports" if it's a namespace (or default) self import in a wrapped asset. Not sure if it should instead maybe insert avar $id = parcelRequire("own id")and then return$id.