New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Node V18, future Deno versions, reduce install size, better performance #7979
Conversation
Please run |
Have you seen this native crash in the integration test that failed on CI?
|
Yes, I did see that, looking into (trying to reproduce). Thanks for letting me know too though. |
…g CI test failure from parcel-bundler/parcel#7979
Do you have any advice on how to interpret the latest CI failure? It seems like I fixed the original issue, but it is not clear to my why the benchmark run is failing (babel errors?) and how that would be caused by lmdb? And it seems other failures were reported, but since resolved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing benchmark is unrelated and doesn't block PR merging.
what's the status of this ticket? I still can't install without errors when using node 18 on Windows 11. Works fine on MacOS Catalina. |
↪️ Pull Request
Just an upgrade of lmdb-js, but could help with a few things. I did (regression) test with one of the repro repo from #7702, seems like everything was working fine.