Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve elm compiler error output #7994

Merged
merged 18 commits into from May 20, 2022
Merged

Improve elm compiler error output #7994

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
336cc59
create elm example for developing
Apr 13, 2022
ab54273
add gitignore
Apr 15, 2022
28e0583
convert elm compiler errors into parcel diagnostics
Apr 15, 2022
121dcd4
Merge branch 'v2' into improve-elm-compiler-error-output
ChristophP Apr 22, 2022
0fdf183
Merge branch 'v2' of github.com:ChristophP/parcel into improve-elm-co…
May 15, 2022
7f056ac
remove elm example
May 15, 2022
12ffb87
change wrapWithIndent cli reporter function to only trim trailing spa…
May 15, 2022
11e0bb4
add `white-space: pre;` to .error-message class of error page
May 15, 2022
70dcac2
Merge branch 'improve-elm-compiler-error-output' of github.com:Christ…
May 15, 2022
bbf62c6
remove elm-stuff from .gitignore
May 15, 2022
819d8c6
remove indentation preserving code in elm transformer
May 15, 2022
2b207ff
add test for elm compiler error diagnostic output
May 15, 2022
6281925
fix linting
May 15, 2022
3194f51
Merge branch 'v2' into improve-elm-compiler-error-output
ChristophP May 15, 2022
177f76b
Fix test description for Elm compilation error
ChristophP May 16, 2022
9f350a2
Merge branch 'v2' into improve-elm-compiler-error-output
mischnic May 17, 2022
35e4785
fix failing elm tests on windows by normalizing path
May 20, 2022
ab79521
try to fix windows test for elm again
May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/core/integration-tests/test/elm.js
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ import {
run,
outputFS,
} from '@parcel/test-utils';
import {normalizePath} from '@parcel/utils';

describe('elm', function () {
it('should produce a basic Elm bundle', async function () {
Expand Down Expand Up @@ -83,6 +84,10 @@ describe('elm', function () {
});

it('should produce correct formatting and indentation when compilation fails', async function () {
const normalizedPath = normalizePath(
'test/integration/elm-compile-error/src/Main.elm',
false,
);
mischnic marked this conversation as resolved.
Show resolved Hide resolved
await assert.rejects(
() =>
bundle(path.join(__dirname, 'integration/elm-compile-error/index.js'), {
Expand All @@ -95,7 +100,7 @@ describe('elm', function () {
{
message:
'\n' +
'-- TYPE MISMATCH --------------- test/integration/elm-compile-error/src/Main.elm\n' +
`-- TYPE MISMATCH --------------- ${normalizedPath}\n` +
'\n' +
'The 1st argument to `text` is not what I expect:\n' +
'\n' +
Expand All @@ -116,7 +121,7 @@ describe('elm', function () {
{
message:
'\n' +
'-- TOO MANY ARGS --------------- test/integration/elm-compile-error/src/Main.elm\n' +
`-- TOO MANY ARGS --------------- ${normalizedPath}\n` +
'\n' +
'The `text` function expects 1 argument, but it got 2 instead.\n' +
'\n' +
Expand Down