Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: should log unsupported type not zero and toLocaleString's option typo #8002

Merged
merged 6 commits into from May 6, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/graph/src/AdjacencyList.js
Expand Up @@ -246,7 +246,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
to: NodeId,
type: TEdgeType | NullEdgeType = 1,
): boolean {
assert(type > 0, `Unsupported edge type ${0}`);
assert(type > 0, `Unsupported edge type ${type}`);

let hash = this.#edges.hash(from, to, type);
let edge = this.#edges.addressOf(hash, from, to, type);
Expand Down Expand Up @@ -600,7 +600,7 @@ export class SharedTypeMap<TItemType, THash, TAddress: number>

get bufferSize(): string {
return `${(this.data.byteLength / 1024 / 1024).toLocaleString(undefined, {
minmumFractionDigits: 2,
minimumFractionDigits: 2,
maximumFractionDigits: 2,
})} mb`;
}
Expand Down