Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue pug rendering by specifying HTML5 by default #8051

Merged
merged 7 commits into from May 8, 2022

Conversation

Jengamon
Copy link
Contributor

@Jengamon Jengamon commented May 3, 2022

↪️ Pull Request

For the pug template engine for Vue, make HTML5 the default. This will fix #7756.
See discussion at #8050 for considerations about this change.

💻 Examples

<template lang="pug">

.wrapper

	p(v-if="false") foo
	p(v-else) bug

</template>

should now render properly without any workarounds.

🚨 Test instructions

I will add the above example as an integration test.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@Jengamon
Copy link
Contributor Author

Jengamon commented May 3, 2022

Does this need a whole integration test?

@devongovett devongovett requested a review from 101arrowz May 8, 2022 15:58
Copy link
Member

@101arrowz 101arrowz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/transformers/vue/src/VueTransformer.js Outdated Show resolved Hide resolved
@devongovett devongovett merged commit 1568064 into parcel-bundler:v2 May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3: "v-else" conditional compilation error in Pug template (SFC)
3 participants