New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExperimentalBundler: merge bundleBehavior for isolated dependencies #8052
Conversation
e031471
to
672a414
Compare
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
672a414
to
95b8588
Compare
I think parcel/packages/core/core/src/Dependency.js Lines 44 to 53 in e51955f
|
95b8588
to
db0550b
Compare
This is probably a blocker for #8000; probably best to decide how exactly duplicate assets with different |
Is this still needed @wbinnssmith @AGawrys? |
This was merged as part of another PR. |
This:
Adds a nullable propertymainEntryAsset
to bundle objects in the ExperimentalBundler for ease of referenceand needsStableNamebased on other incoming dependencies. This is a breaking change from the current bundler, trading potential asset deduplication for bundle deduplication.One case we'll need to handle before landing:
* [ ] Marking a bundle as existing both as an inline bundle and a non-inline bundle. Currently we never write inline bundles to disk. In this case we'll need to.Let's defer this, as it seems like different asset bundleBehavior creates different assets, and as far as I can tell, it's not possible to have a non-inline asset and an inline dependency.Test Plan: Adjusted existing test(s) to use the reduced bundle count