Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc #8135

Merged
merged 6 commits into from May 25, 2022
Merged

Bump swc #8135

merged 6 commits into from May 25, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented May 24, 2022

For swc-project/swc#4761

Currently, anything like this will cause invalid code being get generated:

import { foo } from "./other.js";

let x;
x = {
  ...foo,
};

Changes:

  • There are now individual imports for each helper (import _class_call_check from "@swc/helpers/lib/_class_call_check.js"), as opposed to import * as swcHelpers from "@swc/helpers"; ... swcHelpers.classPrivateFieldInit()

@parcel-benchmark
Copy link

parcel-benchmark commented May 24, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 8.65s -56.00ms
Cached 417.00ms -8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 4.50s +664.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.42m -1.56s
Cached 2.31s +42.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/workerHasher.e50d242f.js 1.72kb +0.00b 34.23s -29.98s 🚀
dist/16.1969624f.js 1.08kb +0.00b 30.91s -4.25s 🚀
dist/16.069344b7.js 905.00b +0.00b 30.91s -4.26s 🚀
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 34.23s -30.03s 🚀
dist/ro.82d888a1.js 633.00b +0.00b 29.91s -1.79s 🚀
dist/index.html 240.00b +0.00b 27.21s -4.49s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.34s +90.00ms
Cached 263.00ms +5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit f1082bd into v2 May 25, 2022
@devongovett devongovett deleted the bump-swc branch May 25, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants