Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when dependency on external helpers is incompatible #8224

Merged
merged 3 commits into from Jun 17, 2022

Conversation

devongovett
Copy link
Member

@swc/helpers had a breaking change, so libraries will need to bump their dependency to remain compatible. This PR adds a diagnostic for that case.

image

Dependencies can now have a range option similar to dev dependencies, which specifies the semver requirement. Currently, it is only checked for external dependencies, but we could add support for checking it for other cases as well if needed. Doing it this way was easier than duplicating all the logic for detecting externals etc. in the transformer, and I think more flexible for future use cases.

@parcel-benchmark
Copy link

parcel-benchmark commented Jun 17, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.53s -29.00ms
Cached 363.00ms -3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 9.61s -40.00ms
Cached 476.00ms -26.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 5.02s +742.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.72m +110.00ms
Cached 2.67s -52.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/esm.c7dc1640.js 61.96kb +0.00b 41.72s -34.80s 🚀
dist/workerHasher.e50d242f.js 1.72kb +0.00b 41.72s -34.80s 🚀
dist/16.1969624f.js 1.08kb +0.00b 37.59s -3.95s 🚀
dist/16.069344b7.js 905.00b +0.00b 37.59s -3.95s 🚀
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 41.72s -34.80s 🚀
dist/index.html 240.00b +0.00b 32.97s -43.60s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.09s +189.00ms
Cached 294.00ms +14.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 54e1769 into v2 Jun 17, 2022
@devongovett devongovett deleted the check-helpers-version branch June 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants