Fix(transformer/elm): handle elm error properly without errors property #8319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinyaigeek
force-pushed
the
fix/handle-elm-error--without-errors-property-properly
branch
from
7ae283a
to
7f918ba
Compare
|
Is this still needed now that #8076 is merged? I tried the test and it seemed to pass against v2. |
|
Oh, sure. As @devongovett said, this change is not needed because #8076 merged. The same as this change is done in https://github.com/parcel-bundler/parcel/pull/8076/files#diff-087bd115f321d7345bbe411da8a4734cf827c1af5af408b74e206f9cd485d305R73-R76. |
|
so I closed this PR. anyway, thank you for review and help! |
|
No worries! Thanks for the PR, and sorry for the duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes: #8263
Hi team! long time to see.
I investigated #8263 issue, and I noticed this bug is caused because
errorobject thrown bycompileToStringmodule does not necessarily have.errorsproperty. I make a fix to handle such a case.💻 Examples
use
Debug.logand build it with production mode.🚨 Test instructions
make a unit test to check such a case.
✔️ PR Todo
Filled out test instructions (In case there aren't any unit tests)