New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify version when resolving Node builtin polyfills #8387
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
92f46e4
Verify version of node builtin
mischnic abe52c8
Fixup
mischnic bbbfd55
Extract getModuleParts
mischnic 5b6419e
Resolve Node builtins from project root
mischnic 6489d3a
Fixup NodePackageManager with builtins
mischnic 4ecff55
Read node polyfill versions from package.json
mischnic 4712d61
Fixup
mischnic 525c802
Fix for Windows
mischnic 6f96992
Declare punycode
mischnic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// @flow strict-local | ||
import path from 'path'; | ||
|
||
import {normalizeSeparators} from './path'; | ||
|
||
/** | ||
* Returns the package name and the optional subpath | ||
*/ | ||
export default function getModuleParts(_name: string): [string, ?string] { | ||
let name = path.normalize(_name); | ||
let splitOn = name.indexOf(path.sep); | ||
if (name.charAt(0) === '@') { | ||
splitOn = name.indexOf(path.sep, splitOn + 1); | ||
} | ||
if (splitOn < 0) { | ||
return [normalizeSeparators(name), undefined]; | ||
} else { | ||
return [ | ||
normalizeSeparators(name.substring(0, splitOn)), | ||
name.substring(splitOn + 1) || undefined, | ||
]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
url
polyfill package declares punycode as a dependencyhttps://github.com/defunctzombie/node-url/blob/5480ec001102457ac00c3c7878facdec39b536c8/package.json#L6-L9
but then does
require("punycode")
which uses the node polyfill (as opposed torequire("punycode/")
). I needed to declare this version to get the integration tests to pass....