New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package on main thread for small rebuilds #8491
Changes from all commits
1cc60d3
87b6a98
43847dd
ad39a49
350e01e
ddf8a34
32bef58
d3ec164
cf5b3ff
51f3575
f58e170
8bf905a
1caafeb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1710,7 +1710,11 @@ export type TextLogEvent = {| | |
/** | ||
* @section reporter | ||
*/ | ||
export type LogEvent = ProgressLogEvent | DiagnosticLogEvent | TextLogEvent; | ||
export type LogEvent = | ||
| ProgressLogEvent | ||
| DiagnosticLogEvent | ||
| TextLogEvent | ||
| BundleGraphEvent; | ||
|
||
/** | ||
* The build just started. | ||
|
@@ -1765,6 +1769,11 @@ export type BundlingProgressEvent = {| | |
+phase: 'bundling', | ||
|}; | ||
|
||
export type BundleGraphEvent = {| | ||
+type: 'bundleGraph', | ||
+bundleGraph: BundleGraph<NamedBundle>, | ||
|}; | ||
Comment on lines
+1772
to
+1775
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What Devon meant in #8491 (comment) is that there could an internal event between PackagerRunner and ReporterRunner (which the reporter runner then just uses for setting the bundle graph but doesn't send it out to the reporter plugins). But I think it's strange to have to split it up into two events in the first place. |
||
|
||
/** | ||
* A new Bundle is being packaged. | ||
* @section reporter | ||
|
@@ -1841,7 +1850,8 @@ export type ReporterEvent = | |
| BuildFailureEvent | ||
| WatchStartEvent | ||
| WatchEndEvent | ||
| ValidationEvent; | ||
| ValidationEvent | ||
| BundleGraphEvent; | ||
|
||
/** | ||
* @section reporter | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I got this logic quite right.. are there any other cases to look for here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either, but I'm confused that the comment says "can't skip all the bundles = at least 1 bundle can't be skipped" but then the if condition checks "there are at least 2 bundles which can't be skipped".