Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make polyfill version validation a warning #8579

Merged
merged 2 commits into from Oct 30, 2022
Merged

Conversation

mischnic
Copy link
Member

Change code from #8387 to a warning instead, as I'm not really confident that there are no false-negatives (cases where the user wants to override themselves)

$ parcel build index.js

@parcel/resolver-default: Could not find module "buffer" satisfying ^5.5.0.

  /.../parcel/tests/builtins-monorepo/package.json:7:3
    6 |   "devDependencies": {
  > 7 |     "buffer": "^4.0.0"
  >   |     ^^^^^^^^ Found this conflicting local requirement.
    8 |   }
    9 | }

✨ Built in 1.50s

dist/index.js    63.74 KB    42ms

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 29, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.43s -7.00ms
Cached 374.00ms +13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 413.00ms -26.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 413.00ms -27.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 413.00ms -27.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.46s +9.46s ⚠️
Cached 471.00ms +472.00ms ⚠️

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.70m +1.70m ⚠️
Cached 2.79s +2.79s ⚠️

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.78s -31.00ms
Cached 293.00ms -30.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 0759d1b into v2 Oct 30, 2022
@mischnic mischnic deleted the builtins-monorepo-warning branch October 30, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants