Suspend incomplete requests #9636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcins
approved these changes
Apr 12, 2024
3 tasks
JakeLane
reviewed
Apr 12, 2024
| for (let filePath of nullthrows( | ||
| devDepRequest.invalidateOnFileChange, | ||
| 'DevDepRequest missing invalidateOnFileChange', | ||
| )) { | ||
| api.invalidateOnFileUpdate(filePath); | ||
| api.invalidateOnFileDelete(filePath); | ||
| } | ||
|
|
||
| for (let invalidation of nullthrows( |
There was a problem hiding this comment.
We should probably look at adding a lint rule to ensure nullthrows always has a description
There was a problem hiding this comment.
Could just change the type definition. It'd be a bit of work though 😅
devongovett
reviewed
Apr 13, 2024
| @@ -1029,6 +1031,10 @@ export default class RequestTracker { | |||
| options: ParcelOptions; | |||
| signal: ?AbortSignal; | |||
| stats: Map<RequestType, number> = new Map(); | |||
| incompleteRequests: Map< | |||
There was a problem hiding this comment.
We already have RequestGraph#incompleteNodeIds and also incompleteNodePromises. Could you use those here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some investigations during a previous PR (#9633) revealed that the long standing DevDepRequest error might be caused by a worker farm-related race condition.
As a possible fix for it, we've added a registry of incomplete requests where we suspend the processing of
runRequestuntil the details have been returned from worker land.It's currently locked behind a feature flag until we've done a bit more testing in the wild.