Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce workspace attributes and add keywords #1077

Merged
merged 7 commits into from
Apr 13, 2023

Conversation

niklasad1
Copy link
Member

Close #970

Cargo.toml Outdated Show resolved Hide resolved
@niklasad1 niklasad1 requested a review from a team April 12, 2023 14:06
documentation = "https://docs.rs/jsonrpsee"
homepage = "https://www.parity.io/"
keywords = ["jsonrpc", "json", "http", "websocket", "WASM"]
readme = "README.md"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how it resolves this in dependencies; does it use the path relative to this workspace toml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah; readme and license paths are relative to the workspace root, ok cool! Not so useful if you want to have crate specific readme's but good if you just want to use the same one for all crates, so makes sense to me!

benches/Cargo.toml Outdated Show resolved Hide resolved
client/transport/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I guess you didn't want to inherit authors for all because those other crates were post-Pierre?

Not sure how README path inherits; maybe it just works; would be good to know :)

@niklasad1
Copy link
Member Author

LGTM; I guess you didn't want to inherit authors for all because those other crates were post-Pierre?

I was just lazy with the test crates, I'll fix it tomorrow.

@niklasad1
Copy link
Member Author

niklasad1 commented Apr 13, 2023

Not sure how README path inherits; maybe it just works; would be good to know :)

According to https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table it should work

Cargo.toml Outdated Show resolved Hide resolved
@niklasad1 niklasad1 merged commit bddbcaf into master Apr 13, 2023
8 checks passed
@niklasad1 niklasad1 deleted the na-introduce-workspace-attr-and-add-keywords branch April 13, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keywords to crates.io page / to crate
3 participants