fix(server): improve too big batch response msg #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
May 2, 2023
lexnv
reviewed
May 2, 2023
| } | ||
|
|
||
| /// Helper to get a `JSON-RPC` error object when the maximum batch response size have been exceeded. | ||
| pub fn reject_too_big_batch_response(limit: usize) -> ErrorObjectOwned { |
There was a problem hiding this comment.
Nit: We could also provide extra insight into how many bytes the message contained, also we could state for clarity the units (ie bytes)
Some(format!("Request length {len} exceeded max limit of {limit} bytes"))This info will also be useful in debugging some tests that are still exceeding the 100 char limit.
Although, I leave this up to you if it makes sense! 👍
There was a problem hiding this comment.
it's a little weird as we terminate when the limit is exceeded as we are processing/building responses
so the entire response could be much bigger than len but for "batch request (input)" that makes sense
lexnv
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.