Fixed connections processing await on server shutdown

[ok-ul-ch]

Fixes #1150

[niklasad1]

Thanks for investing and fixing this issue.

Personally, I have seen something similar when I tried to investigate but never made it this far thank you.

I'm off on vacation for a bit more and I will review it properly when I'm back but I'm not super happy to add this drop-awaiter dependency but maybe not so bad... I saw that you created that library.

[ok-ul-ch]

Hi, @niklasad1. I've removed separate dependency and used the same idea around tokio's mpsc.

[niklasad1]

LGTM, thanks for removing the dependency

[ok-ul-ch]

@niklasad1 pls take a look at failing CI, something odd is happening here. Once I've fixed errors reported by GH actions, it started to fail in Gitlab =)

[jsdw]

The failing test looks offhand to be a UI test where the output has changed a bit (possibly owing to the recent rust release); using something like TRYBUILD=overwrite cargo test should lead to the relevant file being updated I think!

[ok-ul-ch]

@jsdw this is exactly what I did here.
As I see the issue is that Gitlab and GH checks are using different versions of Rust (1.70 and 1.71 respectively), Most likely, Gitlab CI image needs to be updated but I didn't find the repo where I can udpate it

[jsdw]

As I see the issue is that Gitlab and GH checks are using different versions of Rust (1.70 and 1.71 respectively), Most likely, Gitlab CI image needs to be updated but I didn't find the repo where I can udpate it

Aah, ok that makes sense; don't worry about it in that case!

[jsdw]

Looks like a clean approach to me; nice one!