Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc module): make async closures Clone #948

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix(rpc module): make async closures Clone #948

merged 1 commit into from
Nov 23, 2022

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Nov 23, 2022 •
edited

Close #947

It's currently too restrictive with Copy on the closures which forces all types in the closure to be Copy so let's relax it to Clone such that it's possible to use async primitives inside there.

However, it's currently possible to move these primitives to RpcModule to workaround that

@niklasad1 niklasad1 requested a review from a team as a code owner November 23, 2022 10:15
lexnv
lexnv approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@niklasad1 niklasad1 merged commit c904100 into master Nov 23, 2022
@niklasad1 niklasad1 deleted the na-fix-947 branch November 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpc module: register_async_method only allows Copy closures
3 participants
@niklasad1 @Xanewok @lexnv