Don't include bitvec with std feature unless asked for explicitly #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
approved these changes
Sep 13, 2022
bkchr
approved these changes
Sep 13, 2022
I'm not aware of any. We could probably do a minor version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be a breaking code change since bitvec things are all controlled by the "bit-vec" feature, but should avoid pulling in the dep unless it's asked for.
(Part of trying to remove bitvec as a mandatory dependency for consumers (see paritytech/scale-info#168))
Minimum Rust version from this is increased to 1.60.0.
What's our versioning policy w.r.t minimum supported rust version being increased?