staging-xcm: Use versioned_type! for VersionedXcm
#4378
Conversation
dastansam
changed the title
versioned_type! for VersionedXcmstaging-xcm: Use versioned_type! for VersionedXcm
dastansam
force-pushed
the
versioned_type_xcm
branch
from
25162ca
to
8c56d43
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
dastansam
force-pushed
the
versioned_type_xcm
branch
from
8c56d43
to
924df33
Compare
dastansam
force-pushed
the
versioned_type_xcm
branch
from
924df33
to
37c8a6b
Compare
polkadot/xcm/src/lib.rs
Outdated
| VersionedXcm::V2(x) | ||
| } | ||
| } | ||
|
|
||
| impl<RuntimeCall> From<v3::Xcm<RuntimeCall>> for VersionedXcm<RuntimeCall> { |
polkadot/xcm/src/lib.rs
Outdated
| @@ -77,6 +77,37 @@ pub trait TryAs<T> { | |||
| } | |||
|
|
|||
| macro_rules! versioned_type { | |||
| (@internal $n:ident, $v3:ty, ) => { | |||
| // only impl `MaxEncodedLen` for enums without generic type parameters | |||
There was a problem hiding this comment.
It makes no sense that this is separate.
There was a problem hiding this comment.
MaxEncodedLen is not implemented for Xcm structs of VersionedXcm, so impl it fails. This is a workaround I did to exclude VersionedXcm from it implementing MaxEncodedLen. Open to suggestions for a more idiomatic way of handling it
polkadot/xcm/src/lib.rs
Outdated
| // only impl `MaxEncodedLen` for enums without generic type parameters | ||
| impl MaxEncodedLen for $n { | ||
| fn max_encoded_len() -> usize { | ||
| <$v3>::max_encoded_len() |
There was a problem hiding this comment.
This should be the max of all variants.
There was a problem hiding this comment.
some enums' 2nd versions do not implement MaxEncodedLen, v3 and v4 all implement it, so I am now taking max of v3 and v4
closes #3846