stake-tracker remote externalities tests + improvements

[gpestana]

Changes in the migration code introduced in this PR:

• Migration removes duplicate nominations in all nominators, if they exist (changes by calling fn do_add_nominator with dedup nominations)
• Migration removes all the non active validator nominations to avoid adding dangling nominations (changes by calling fn do_add_nominator if necessary)
• Migration iterates through all Nominators map first and through all the Validators map to insert all the validators that are not nominated to the target list (with self-stake only).
• Moves stake-tracker related try-state checks to the staking pallet (no try-state checks in the stake-tracker pallet anymore).
• Runs benchmarks for MMB migration step with bench bot.

The migration code has been validated against the Polkadot using the externalities tests in polkadot/runtime/westend/src/lib.rs. Upon running the migrations, we ensure that:

• All validators have been added to the target list with their correct approvals score;
• All nominations are "cleaned" (see def. of clean above)
• Try-state checks related to stake-tracker and approvals pass.

[gpestana]

bot bench polkadot-pallet --runtime=westend --pallet=pallet-staking

[command-bot]

@gpestana option '--pallet ' argument 'pallet-staking' is invalid. argument pallet is not matching rule ^([a-z_]+)([:]{2}[a-z_]+)?$

[gpestana]

bot bench polkadot-pallet --runtime=westend --pallet=pallet_staking

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6179886 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-8ad50ea4-362e-4a69-9066-c416c8d669c4 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6179886 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6179886/artifacts/download.

[kianenigma]

what is the example execution output? any insights or results?

[gpestana]

what is the example execution output? any insights or results?

The migration and try-state in this branch are working now.

There were a few edge side-cases that we had to change in this PR, I'll add them to the comments and then merge this PR into the main PR branch.

[gpestana]

bot bench polkadot-pallet --runtime=westend --pallet=pallet_staking

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6349082 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-43f7f098-94da-42be-8c42-42736492902a to cancel this command or bot cancel to cancel all commands in this pull request.

[gpestana]

TODO: remove these tests before merging in the base branch.

[gpestana]

bot bench polkadot-pallet --runtime=westend --pallet=pallet_staking

[command-bot]

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6350207 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-0a2894d9-f5b7-4f9b-9cfb-b6eff3def51d to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6349082 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6349082/artifacts/download.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6351824

[command-bot]

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6350207 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6350207/artifacts/download.