-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relates to #2750: Fix Substrate Docker #4450
Open
ltfschoen
wants to merge
15
commits into
paritytech:master
Choose a base branch
from
ltfschoen:fix-2750-substrate-docker-file
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Relates to #2750: Fix Substrate Docker #4450
ltfschoen
wants to merge
15
commits into
paritytech:master
from
ltfschoen:fix-2750-substrate-docker-file
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to provide a fix so that if you run
./substrate/docker/build.sh
from the project root directory of the polkadot-sdk, it will build a Docker container that has all relevant substrate-related binaries available.That is the command that I've been running whilst using Docker Desktop for Mac 4.22.0 (117440), using macOS Sonoma 14.1.1.
I believe it should allow the user to have access to the binary of the following polkadot-sdk packages names:
where those packages generate the following binaries:
But NOT
polkadot-parachain
just yet, since it generates an error #4448.So far I am trying to add support for all of those binaries, even though later some of those could go into a different Dockerfile, by specifically building those packages here.
So rather than building everything with
cargo build --workspace --locked --release
in the workspace, we allow them to choose specific packages that are relevant (or only those that don't generate an error).The progress made in trying fix #2750 include this error:
Where the fix has just been to modify this line so it finds the Cargo.toml in the project root https://github.com/paritytech/polkadot-sdk/compare/master...ltfschoen:polkadot-sdk:fix-2750-substrate-docker-file?expand=1#diff-42b72709c8ec68097a5de02440c9263d5c0c3acbd13076b482183991597b8e49R6
The next error was:
Where the solution has been to go through each of the packages and change it like this https://github.com/paritytech/polkadot-sdk/compare/master...ltfschoen:polkadot-sdk:fix-2750-substrate-docker-file?expand=1#diff-19bdfdcfbc7d4526e1df401f04e4fa041ed5cc9ce9b44ec234dedf9301c7585cR46
Then the next issue was this error:
That error is because at the top of substrate/docker/substrate_builder.Dockerfile here it depends on docker.io/paritytech/ci-linux:production that is using an old version
RUST_NIGHTLY=2023-05-23
that breaks the build.So to fix that I could either create a PR to modify https://github.com/paritytech/scripts/blob/master/dockerfiles/ci-linux/Dockerfile to use the latest Rust nightly version that is compatible with the latest polkadot-sdk, and if the PR gets merged then a new release of docker.io/paritytech/ci-linux:production would get created and that would hopefully resolve this issue.
But instead I decided to just add the proposed modifications here to resolve that error.
Then there was a warning
That I fixed here
Then there was another error that I resolved somehow (can't remember how I solved it)
Then i got this error:
Which I solved here by adding the lines
Then I got error:
Which is because the
node-template
binary has been replaced with other templates in the ./templates folder of the polkadot-sdk that i mentioned earlier, such assolochain-template-node
andminimal-template-node
, so i've replaced that with the latest binaries hereNow that latest error that I've gotten has been the one that i've reported in this issue #4448, and i still haven't resolved it yet.
This PR now compiles.