Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema generation #178

Merged
merged 17 commits into from
Apr 25, 2023
Merged

Schema generation #178

merged 17 commits into from
Apr 25, 2023

Conversation

SkymanOne
Copy link
Contributor

@SkymanOne SkymanOne commented Apr 22, 2023

This PR adds support for schema generation required for ink! metadata verification. All types are now derive schemars::JsonSchema under an optional feature flag schema

@SkymanOne SkymanOne requested a review from ascjones April 22, 2023 20:56
src/form.rs Outdated Show resolved Hide resolved
src/form.rs Outdated Show resolved Hide resolved
src/meta_type.rs Show resolved Hide resolved
src/form.rs Outdated Show resolved Hide resolved
@SkymanOne SkymanOne requested a review from ascjones April 24, 2023 19:22
Copy link
Member

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line here

cargo check --no-default-features --features serde,decode
to test that feature on its own e.g. cargo check --no-default-features --features schema. At the moment that fails for me.

src/form.rs Outdated Show resolved Hide resolved
src/form.rs Outdated Show resolved Hide resolved
@SkymanOne SkymanOne requested a review from ascjones April 25, 2023 09:29
Copy link
Member

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Should be good to be a minor (non-breaking) release 👍

src/registry.rs Outdated Show resolved Hide resolved
@SkymanOne SkymanOne merged commit 62ac3d6 into master Apr 25, 2023
1 check passed
@SkymanOne SkymanOne deleted the gn/json-schema branch April 25, 2023 21:17
@SkymanOne SkymanOne mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants