Implement TypeInfo for Arc
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
May 15, 2023
niklasad1
approved these changes
May 15, 2023
ascjones
approved these changes
May 15, 2023
| type Identity = T; | ||
|
|
||
| fn type_info() -> Type { | ||
| Self::Identity::type_info() |
There was a problem hiding this comment.
We may want to revisit the idea of adding some extra information about transparent wrapper types like this, e.g. for Box to avoid https://github.com/paritytech/subxt/blob/c08eb6c8f1ae1ea61964196733008cc3a4bfb627/codegen/src/types/composite_def.rs#L307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to replace a
Boxin one of the structs which implementsTypeInfowith anArc, butTypeInfois not implemented forArc, so let's make it that it is.