CI: add GHA to build/publish Docker image #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejparity
requested review from
ascjones,
cmichi and
a team
as code owners
alvicsam
approved these changes
Jan 18, 2024
smiasojed
reviewed
Jan 18, 2024
|
|
||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
I think that we should not upload docker image on push to master because we are going to upload to this branch stats from benchmark execution each day.
I see 2 options:
- push the benchmarks stats to a different branch, maybe gh-pages?
- before uploading docker we should check if anything has change apart of stats
There was a problem hiding this comment.
@smiasojed But what will be the pattern (files or folders) of changes? Stats will be pushed to some folder?
So we can setup paths/paths-ignore for push events which will lead to release of new Docker image.
There was a problem hiding this comment.
results/.csv results/.png
There was a problem hiding this comment.
So we can just ignore whole results folder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/paritytech/ci_cd/issues/830
GHA introduced by this PR tests building of Docker image in PR's.
And builds/publishes Docker image to hub.docker.com when PR is merged to
masterbranch.!!! BEFORE MERGE
Setup environment
masterand add there secrets DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD