Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bins: polkadot and zombienet #60

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

karolk91
Copy link
Contributor

@karolk91 karolk91 commented Mar 5, 2024

Polkadot update to 1.7.0 + additional worker binaries dependencies Zombienet update to 1.3.91

Update parachain metadata with new polkadot-parachain

Polkadot update to 1.7.0 + additional worker binaries dependencies
Zombienet update to 1.3.91

Update parachain metadata with new polkadot-parachain
@karolk91
Copy link
Contributor Author

karolk91 commented Mar 5, 2024

This PR is not ready to be merged as polkadot or polkadot-parachain with version (1.1.0 - 1.5.0 not tested) 1.6.0+ has an issue that yields extrinsics invalid when submitting lots of them using single account:

2024-02-15 22:41:48.366 TRACE tokio-runtime-worker basic-authorship: [Parachain] [0xaa5a84cdf9b3cc6c143bc001681066553c6f2e478a4a89d11d5696546edd7945] Pushing to the block.
2024-02-15 22:41:48.371 DEBUG tokio-runtime-worker basic-authorship: [Parachain] [0xaa5a84cdf9b3cc6c143bc001681066553c6f2e478a4a89d11d5696546edd7945] Pushed to the block.
2024-02-15 22:41:48.396 TRACE tokio-runtime-worker basic-authorship: [Parachain] [0x1f1b7de2df5983d5ac5b027689f4f5303cc8bd4bb5d8e20a3628ea3bacd8041f] Pushing to the block.
2024-02-15 22:41:48.397 DEBUG tokio-runtime-worker basic-authorship: [Parachain] [0x1f1b7de2df5983d5ac5b027689f4f5303cc8bd4bb5d8e20a3628ea3bacd8041f] Invalid transaction: Extrinsic is not valid: TransactionValidityError::Invalid(InvalidTransaction::Future)

@karolk91 karolk91 marked this pull request as ready for review April 25, 2024 21:43
@@ -0,0 +1,43 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the options to enable async backing?:

[relaychain.genesis.runtimeGenesis.patch.configuration.config]
  scheduling_lookahead = 2

[relaychain.genesis.runtimeGenesis.patch.configuration.config.async_backing_params]
  max_candidate_depth = 3
  allowed_ancestry_len = 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but these options doesn't have any effect on resulting relay chain configuration (tried with most recent version of zombienet)

but I have noticed that (regardless of the options above being present or not in the zombienet config)

  1. relay chain based on Polkadot 1.7.0 and older, results in following default configuration:
"async_backing_params": {
  "allowed_ancestry_len": 0,
  "max_candidate_depth": 0
},
  1. Polkadot 1.8.0 and newer default configuration changes to:
"async_backing_params": {
  "allowed_ancestry_len": 2,
  "max_candidate_depth": 3
},

1. Gather smart-bench benchmarking results in CSV format
1. make use of an utility script `smart_bench_to_csv.sh`. Run it against smart-bench software multiple times to gather statistics data. Make sure to use meaningful timestamps. For example (any method to run smart-bench):
```
cargo run --release -- evm flipper --instance-count 1 --call-count 1500 --url ws://localhost:9988 | ./smart_bench_to_csv.sh --csv-output=benchmark-result.csv --timestamp=1714515934
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe timestamp should be from the time of the script execution?

@smiasojed
Copy link
Contributor

please update v1.7.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants