Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance public api #209

Merged
merged 3 commits into from
May 14, 2024
Merged

feat: enhance public api #209

merged 3 commits into from
May 14, 2024

Conversation

evilrobot-01
Copy link
Contributor

Firstly, thank you for an amazing library! The original zombienet is a Polkadot staple and now being able to use it completely from Rust is a game changer for us: as you may be aware, we have integrated zombienet-sdk with pop-cli.

In doing so, we needed to add a few getters to the public api to be able to present certain information to the user, as well we expose a little more of the inner errors. This PR simply upstreams these changes.

It also includes two additional fixes, which may be better implemented based on your guidance:

  • collator args werent working for us when specified in a config file, which seemed to be due to missing -- in the args list provided by calling functions.
  • artifact path wasnt set when trying to build a chain spec. This may no longer be required based on the changes in c7ce50c

I am happy to add tests if you are open to these changes. 馃檪

@pepoviola
Copy link
Collaborator

Hi @evilrobot-01, thanks for your feedback, the fixes and for using zombienet-sdk 馃檶 . Changes in the api looks good to me, I will merge those and publish a new version.

Thanks!!

@pepoviola pepoviola self-requested a review May 14, 2024 14:12
@pepoviola pepoviola merged commit 11ea125 into paritytech:main May 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants