-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rich message buttons #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also needed the ref for ReplyActions so i could set the `reply` in the state. For this i needed to remove the `forwardRef()`. After removing this all the tests still worked and also the ref (for which it was added i guess) still worked. So i think this wasn't necessary anymore...
… feature/addButtons
daanleenders
requested changes
May 10, 2024
There is no need to try and reuse the "submitHandler" from ResultActions, because the reply button doesn't need to - disable the text field - check if the payload is empty (it is never empty thanks to the validation done in the api) - put focus on the text area (that wasn't the last place the client focused on)
daanleenders
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alle changes sinds vorige review zijn goed. Er zijn wel nog 2 niet resolved comments.
daanleenders
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the buttons rich text message to the conversation.
The types of buttons are explained here: https://developers.parley.nu/docs/rich-messages#buttons