Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse.Installation doesn't handle deleted Installation objects on server #2124

Closed
4 tasks done
dplewis opened this issue May 14, 2024 · 3 comments · Fixed by #2126
Closed
4 tasks done

Parse.Installation doesn't handle deleted Installation objects on server #2124

dplewis opened this issue May 14, 2024 · 3 comments · Fixed by #2126
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@dplewis
Copy link
Member

dplewis commented May 14, 2024 •
edited

New Issue Checklist

Issue Description

Deleted an installation in the database and it gets into a state where nothing works and it doesn't seem to be a way to get out of it.

The InstallationController never checks for server changes to object, so save() just fails since the local object has an id. And beyond cleaning the cache keys manually out of storage, there is no way to reset the installation locally.

Steps to reproduce

  1. Save the current installation
  2. Delete it via Parse Dashboard
  3. Try to get the current installation and save it.

Approach

Parse Installation in the iOS SDK and this SDK should have similar functionaility.

Installations cannot be deleted

We always want [currentInstallation fetch] to succeed.

We always want [currentInstallation save] to succeed.

Actual Outcome

The cache has a mismatch with the server and fails.

Expected Outcome

Should properly save, fetch the installation always.
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented May 14, 2024 •
edited

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@dplewis dplewis mentioned this issue May 15, 2024
Merged
2 tasks
@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label May 16, 2024
@mtrezza
Copy link
Member

mtrezza commented May 16, 2024 •
edited

Hans't this been discussed somewhere before opening this issue? Could you link the other issue?

@dplewis
Copy link
Member Author

dplewis commented May 16, 2024 •
edited

@mtrezza It was in an already merged PR. #2119 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Parse.Installation not working when installation is deleted on server dplewis/Parse-SDK-JS
2 participants
@mtrezza @dplewis