fix: Parse.Installation not working when installation is deleted on server
#2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2126 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 61 64 +3
Lines 6186 6348 +162
Branches 1499 1505 +6
==========================================
+ Hits 6186 6348 +162 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Diamond Lewis <findlewis@gmail.com>
|
@mtrezza Conflicts have been resolve and this is ready for review. |
mtrezza
approved these changes
May 16, 2024
mtrezza
changed the title
Parse.Installation not working when installation is deleted on the serverParse.Installation not working when installation is deleted on server
parseplatformorg
pushed a commit
that referenced
this pull request
May 16, 2024
## [5.1.1-alpha.1](5.1.0...5.1.1-alpha.1) (2024-05-16) ### Bug Fixes * `Parse.Installation` not working when installation is deleted on server ([#2126](#2126)) ([22360b4](22360b4))
|
🎉 This change has been released in version 5.1.1-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
The InstallationController never checks for server changes to object, so save() just fails since the local object has an id. And beyond cleaning the cache keys manually out of storage, there is no way to reset the installation locally.
Closes: #2124
Approach
Ensure a new installation is created if installation is not found on the server when fetching / saving. This approach was taken from the iOS SDK
Tasks