Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: Scrolling issue demo [do not merge] #2486

Closed
wants to merge 4 commits into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jun 28, 2023

New Pull Request Checklist

Issue Description

Closes: #2045 (comment)

Approach

This is just a demo for the scrolling issue that has been introduced with #2457. See #2045 (comment).

This PR is not supposed to be merged.

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: scrollbar issue demo fix: Scrollbar issue demo Jun 28, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 28, 2023

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title fix: Scrollbar issue demo invalid: Scrolling issue demo [do not merge] Jun 28, 2023
@mtrezza mtrezza changed the title invalid: Scrolling issue demo [do not merge] fix: Scrolling issue demo [do not merge] Jun 28, 2023
@mtrezza mtrezza changed the title fix: Scrolling issue demo [do not merge] invalid: Scrolling issue demo [do not merge] Jun 28, 2023
@mtrezza mtrezza changed the title invalid: Scrolling issue demo [do not merge] demo: Scrolling issue demo [do not merge] Jun 28, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jun 28, 2023

Uffizzi Ephemeral Environment deployment-29690

⌚ Updated Jun 28, 2023, 19:21 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2486

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member Author

mtrezza commented Jun 28, 2023

@AshishBarvaliya here are the instructions to replicate the scroll issue described in #2045 (comment):

  1. Open the preview environment
  2. Open class "MyClass"
  3. Scroll to the very right and very bottom corner
  4. Open class "_User"
  5. Notice that the scroll position is already strange, there is a lot of blank space to scroll around, even thought there are 0 rows
  6. Click on "Add row" button in the top bar
  7. Scroll to the top (but keep scrolled to the very right)
  8. Scroll to the left and see how the headers move independently from the row fields
Screen.Recording.2023-06-28.at.22.02.00.mov

@AshishBarvaliya
Copy link
Member

@mtrezza I don't know what I am missing here but I am still not able to reproduce the issue.

ezgif-1-17d30cae2c

@mtrezza
Copy link
Member Author

mtrezza commented Jul 6, 2023

Looks like a browser compatibility issue. I'm using Safari Version 16.4 (18615.1.26.110.1) and I'm able to reproduce the issue with the preview environment and following the same steps in your video. What browser are you using?

@mtrezza
Copy link
Member Author

mtrezza commented Jul 16, 2023

@AshishBarvaliya Were you able to reproduce this?

@AshishBarvaliya
Copy link
Member

Seems like width: calc(100% - 300px); was causing the issue in Safari. Please try with this alternative suggestions.

@mtrezza mtrezza closed this Jul 19, 2023
@mtrezza mtrezza reopened this Jul 19, 2023
@mtrezza
Copy link
Member Author

mtrezza commented Jul 19, 2023

Done, lets see how it goes when the preview env is recreated

@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jul 19, 2023

Uffizzi Ephemeral Environment deployment-31232

⌚ Updated Jul 19, 2023, 00:16 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2486

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member Author

mtrezza commented Jul 22, 2023

The issue now is that when scrolling into the bottom right corner, and then changing to a different class with many rows, the data browser does not start at the top most (first) row, but at a lower row.

Screen.Recording.2023-07-23.at.01.45.57.mov

@mtrezza mtrezza closed this May 16, 2024
@mtrezza mtrezza deleted the fix-scrollbar branch May 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical scrollbar is shown inside the horizontally scrollable area, which makes it usually out of sight
2 participants