Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select rows in data browser by clicking and dragging mouse cursor over checkboxes #2548

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

AshishBarvaliya
Copy link
Member

New Pull Request Checklist

Issue Description

Select rows by pressing and dragging cursor over checkboxes

Closes: #2546

Approach

Implemented the feature by simply using the mousedown, mouseup, and mouseover events on the checkbox tag.

Copy link

parse-github-assistant bot commented Apr 23, 2024

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Apr 23, 2024

I'm surprised there is no preview environment. Let's see how long this takes, or whether it's a bug.

@mtrezza mtrezza closed this Apr 24, 2024
@mtrezza mtrezza reopened this Apr 24, 2024
@mtrezza mtrezza closed this Apr 24, 2024
@mtrezza mtrezza reopened this Apr 24, 2024
Copy link

uffizzi-cloud bot commented Apr 24, 2024

Uffizzi Ephemeral Environment deployment-50797

⌚ Updated Apr 24, 2024, 19:39 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2548

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member

mtrezza commented Apr 24, 2024

Very nicely done! Just one more thing if you don't mind: could you make the whole cell with the checkbox clickable, instead of only the checkbox? Because the checkbox itself is quite small and a click in the rest of the cell around the checkbox doesn't do anything, so we have a lot of unused space. That would greatly improve usability when selecting a row.

@mtrezza mtrezza changed the title feat: Select rows by pressing and dragging cursor over checkboxes feat: Select rows in data browser by pressing and dragging cursor over checkboxes Apr 24, 2024
@mtrezza mtrezza changed the title feat: Select rows in data browser by pressing and dragging cursor over checkboxes feat: Select rows in data browser by clicking and dragging mouse cursor over checkboxes Apr 24, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 792ba9e into parse-community:alpha Apr 30, 2024
9 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 30, 2024
# [6.0.0-alpha.3](6.0.0-alpha.2...6.0.0-alpha.3) (2024-04-30)

### Features

* Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 30, 2024
parseplatformorg pushed a commit that referenced this pull request May 16, 2024
# [6.0.0-beta.1](5.4.0...6.0.0-beta.1) (2024-05-16)

### Bug Fixes

* App metrics for user and installation counts show dash ([#2528](#2528)) ([850d7b3](850d7b3))
* Class Level Permissions dialog throws error `TypeError: ce.current is null` for newly created class ([#2549](#2549)) ([27ed692](27ed692))
* Config page fails to load ([#2531](#2531)) ([d721b7c](d721b7c))
* Dashboard crashes if Parse Server Cloud Function script returns object ([#2516](#2516)) ([5de08f8](5de08f8))
* Dashboard scrolls when selecting row in data browser ([#2559](#2559)) ([2aa54a5](2aa54a5))
* Data browser redirects to wrong class when changing app ([#2526](#2526)) ([7713f54](7713f54))
* Deleting all code in the JS Console editor fills in the default code ([#2558](#2558)) ([4b830ba](4b830ba))
* Open pointer in new tab in data browser not working when mount path is not root ([#2527](#2527)) ([2f4081f](2f4081f))

### Features

* Add descriptive statistics for number cells in data browser ([#2529](#2529)) ([ead9ec4](ead9ec4))
* Add filter `starts with` in data browser for fields of type Pointer ([#2553](#2553)) ([0b94ab6](0b94ab6))
* Add Node 20 support; remove Node 14, 16 support ([#2532](#2532)) ([578a339](578a339))
* Add Node 20 support; remove Node 14, 16 support ([#2535](#2535)) ([5c90f2d](5c90f2d))
* Execute script for selected rows ([#2508](#2508)) ([5d9901e](5d9901e))
* Select rows in data browser by clicking and dragging mouse cursor over checkboxes ([#2548](#2548)) ([792ba9e](792ba9e))

### BREAKING CHANGES

* Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select rows by pressing and dragging cursor over checkboxes
3 participants