Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node 16 support; remove node 15 support #7558

Closed
wants to merge 39 commits into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 8, 2021

New Pull Request Checklist

Issue Description

Node 15 reached its EOL; Node 16 is the current version

Related issue: #n/a

Approach

  • remove node 15 from ci
  • add node 16 to ci
  • use node 16 as default

This appears to not be merely a CI change, but to require some minor changes in parse server / dependencies. Hence this PR will likely be a feat commit.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 8, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #7558 (4850953) into alpha (a359c02) will decrease coverage by 9.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7558      +/-   ##
==========================================
- Coverage   93.99%   84.19%   -9.80%     
==========================================
  Files         181      181              
  Lines       13382    13382              
==========================================
- Hits        12578    11267    -1311     
- Misses        804     2115    +1311     
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.47% <0.00%> (-92.90%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 5.00% <0.00%> (-65.00%) ⬇️
src/batch.js 75.86% <0.00%> (-15.52%) ⬇️
src/ParseServerRESTController.js 82.08% <0.00%> (-14.93%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.10% <0.00%> (-2.59%) ⬇️
src/Controllers/UserController.js 95.34% <0.00%> (-2.33%) ⬇️
src/Controllers/FilesController.js 92.00% <0.00%> (-2.00%) ⬇️
src/Controllers/DatabaseController.js 92.63% <0.00%> (-1.16%) ⬇️
src/Controllers/index.js 96.66% <0.00%> (-1.12%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a359c02...4850953. Read the comment docs.

@mtrezza mtrezza changed the title ci: remove node 15, add node 16 support ci: add node 16 support; remove node 15 support Sep 14, 2021
@funkenstrahlen
Copy link
Contributor

👍

@mtrezza
Copy link
Member Author

mtrezza commented Oct 20, 2021

Yes, this has become stale because of other CI changes that have been prioritized. If anyone wants to pick this up in the meantime, please feel free.

@mtrezza mtrezza mentioned this pull request Oct 30, 2021
3 tasks
@mtrezza mtrezza linked an issue Oct 30, 2021 that may be closed by this pull request
3 tasks
@mtrezza mtrezza changed the title ci: add node 16 support; remove node 15 support feat: add node 16 support; remove node 15 support Oct 30, 2021
@marvinroger
Copy link
Contributor

This PR can now be closed 😉

@mtrezza
Copy link
Member Author

mtrezza commented Nov 19, 2021

Closing in favor of #7707

@mtrezza mtrezza closed this Nov 19, 2021
@mtrezza mtrezza deleted the ci-remove-node-15 branch March 24, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node 16 support
3 participants