Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix single precision configuration #771

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Oct 27, 2022

PR Summary

In theory we already supported single precision.
In practice, it didn't work (not even compilation).

Todos:

  • Add test coverage for single prec
  • Check that all time/timing related parameters are Real64
  • Check that all reductions, reduce to Real64
    • kernels
    • MPI
  • check use of Real override in unit tests
  • Discuss
    • (fixed) type for particles positions
    • (fixed) type for coordinates

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • (@lanl.gov employees) Update copyright on changed files

@pgrete
Copy link
Collaborator Author

pgrete commented Oct 27, 2022

@brryan I encountered some interesting behavior for particles when I tried to compile in single precision.
Most of the position ("x", "y", "z") related function were hard-coded to double, which I understand.
However, the Views themselves were Real resulting in a mismatch when trying to get the data because the map would return Real where doubles are expected in further processing.
Hardcoding the positions to double/Real64 could be an option, but it would require to add just another map next to int and Real.
What's your take on this?

@Yurlungur
Copy link
Collaborator

@pgrete @brryan what's the status here?

@pgrete
Copy link
Collaborator Author

pgrete commented Apr 21, 2023

Probably still not working and needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants