Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Change deprecated kokkos-num-devices to kokkos-map-device-id for ctest #934

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

forrestglines
Copy link
Collaborator

PR Summary

Apparently the kokkos command line option --kokkos-num-devices is deprecated Per Kokkos' suggestion changing this in testing to --kokkos-map-device-id-by=mpi_rank allows us to forgo specifying NUM_GPU_DEVICES_PER_NODE, making building+testing simpler.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@pgrete
Copy link
Collaborator

pgrete commented Sep 22, 2023

Do we want to get rid of that parameter entirely?
As far as I can tell it's only used in the "test precheck" as a warning, but otherwise the numbers are hardcoded to each machine in the machine file anyway.

@pgrete pgrete changed the title Change deprecated kokkos-num-devices to kokkos-map-device-id for ctest WIP: Change deprecated kokkos-num-devices to kokkos-map-device-id for ctest Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants