Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-16718) fix(Search): usage of algoliasearch client lite #3523

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

kopax-polyconseil
Copy link
Contributor

@kopax-polyconseil kopax-polyconseil commented Sep 7, 2022

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-16718

Description

There is an algoliasearch client lite available in ESM format.

Unfortunetaly, the typing/exports and package.json is poorly configured for the lite version but the needed features are available in it:

  • search
  • multipleQueries

The light client will fit for our application until we do not use anything else than the search features/perms.

Read documentation

To prevent patch-package un the futur, we have opened this issue: algolia/algoliasearch-client-javascript#1424

Checklist

I have:

  • Made sure the title of my PR follows the convention ($jira) $type($scope): $summary.
  • Made sure my feature is working on the relevant real / virtual devices (native and web).
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets.
  • Added new reusable components to AppComponents page and communicate to the team on slack.
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

iOS Android Mobile - Chrome Desktop - Chrome Desktop - Safari

@kopax-polyconseil kopax-polyconseil marked this pull request as ready for review September 8, 2022 10:30
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kopax-polyconseil kopax-polyconseil requested review from voisinhugo and removed request for Lucasbeneston September 9, 2022 11:59
@kopax-polyconseil kopax-polyconseil merged commit 3064f9f into master Sep 9, 2022
@kopax-polyconseil kopax-polyconseil deleted the PC-16718 branch September 9, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants