Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BSR) build(storybook): upgrade @chanzuckerberg/axe-storybook-testing from 7.1.1 to 7.1.2 #5550

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

kopax-polyconseil
Copy link
Contributor

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-XXXXX

Issue: microsoft/playwright#24028

Autrement yarn install fail sur Debian 12 :

Output:
/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/node_modules/@chanzuckerberg/axe-storybook-testing/node_modules/playwright-core/lib/server/registry/index.js:684
    if (!downloadURLs.length) throw new Error(`ERROR: Playwright does not support ${descriptor.name} on ${_hostPlatform.hostPlatform}`);
                                    ^

Error: ERROR: Playwright does not support firefox on debian12
    at Registry._downloadExecutable (/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/node_modules/@chanzuckerberg/axe-storybook-testing/node_modules/playwright-core/lib/server/registry/index.js:684:37)
    at Object._install (/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/node_modules/@chanzuckerberg/axe-storybook-testing/node_modules/playwright-core/lib/server/registry/index.js:463:28)
    at Registry.install (/home/dka/workspace/github.com/pass-culture/pass-culture-app-native/node_modules/@chanzuckerberg/axe-storybook-testing/node_modules/playwright-core/lib/server/registry/index.js:642:26)

Ceci à cause de la cmd npx playwright install-deps qui n'a pas les deps nécessaire sur debian bookwrom :

❯ npx playwright install-deps
BEWARE: your OS is not officially supported by Playwright; installing dependencies for Ubuntu as a fallback.
Installing dependencies...
Switching to root user to install dependencies...
Hit:1 http://security.debian.org/debian-security bookworm-security InRelease
Get:2 http://deb.debian.org/debian bookworm InRelease [151 kB]                                             
Hit:3 http://deb.debian.org/debian bookworm-updates InRelease                                                         
Hit:4 https://dl.google.com/linux/chrome/deb stable InRelease                                             
Hit:5 https://download.docker.com/linux/debian bookworm InRelease                   
Fetched 151 kB in 1s (135 kB/s)       
Reading package lists... Done
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'libfontconfig1' instead of 'libfontconfig'
Package ttf-ubuntu-font-family is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package ttf-unifont is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  fonts-unifont

Package xfonts-cyrillic is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'ttf-unifont' has no installation candidate
E: Package 'xfonts-cyrillic' has no installation candidate
E: Package 'ttf-ubuntu-font-family' has no installation candidate
E: Unable to locate package libenchant1c2a
E: Unable to locate package libvpx6
E: Unable to locate package libwebp6
Failed to install browser dependencies
Error: Installation process exited with code: 100

Checklist

I have:

  • Made sure my feature is working on the relevant real / virtual devices (native and web).
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

github-actions bot commented Nov 6, 2023

Performance Comparison Report

Significant Changes To Render Duration

Name Render Duration Render Count
Performance test for Venue page 425.7 ms → 405.9 ms (-19.8 ms, -4.7%) 11 → 11
Show details
Name Render Duration Render Count
Performance test for Venue page Baseline
Mean: 425.7 ms
Stdev: 9.4 ms (2.2%)
Runs: 442 435 431 429 424 423 423 423 420 407

Current
Mean: 405.9 ms
Stdev: 10.6 ms (2.6%)
Runs: 418 417 416 416 410 402 398 397 394 391
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 40.9 ms → 40.5 ms (-0.4 ms, -1.0%) 8 → 8
Search Suggestions - Performance test for Search Suggestions page 53.5 ms → 52.8 ms (-0.7 ms, -1.3%) 11 → 11
Search Results - Performance test for Search Results page 124.6 ms → 123.5 ms (-1.1 ms, -0.9%) 16 → 16
Performance test for EndedBookings page 24.0 ms → 22.7 ms (-1.3 ms, -5.4%) 7 → 7
Search Landing Page - Performance test for Search Landing page 86.6 ms → 85.0 ms (-1.6 ms, -1.8%) 10 → 10
Performance test for Profile page 97.8 ms → 96.1 ms (-1.7 ms, -1.7%) 8 → 8
Performance test for Offer page 520.2 ms → 518.5 ms (-1.7 ms, ±0.0%) 14 → 14
Performance test for Favorites page 111.6 ms → 109.5 ms (-2.1 ms, -1.9%) 9 → 9
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 40.9 ms
Stdev: 2.9 ms (7.1%)
Runs: 46 43 43 42 42 41 39 39 38 36

Current
Mean: 40.5 ms
Stdev: 3.1 ms (7.7%)
Runs: 45 44 42 41 41 41 40 39 38 34
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Search Suggestions - Performance test for Search Suggestions page Baseline
Mean: 53.5 ms
Stdev: 3.2 ms (5.9%)
Runs: 58 56 55 54 54 54 54 54 48 48

Current
Mean: 52.8 ms
Stdev: 3.9 ms (7.4%)
Runs: 60 56 55 55 54 52 50 50 48 48
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Search Results - Performance test for Search Results page Baseline
Mean: 124.6 ms
Stdev: 1.9 ms (1.5%)
Runs: 126 126 126 126 126 126 123 123 123 121

Current
Mean: 123.5 ms
Stdev: 1.6 ms (1.3%)
Runs: 126 126 125 124 123 123 122 122 122 122
Baseline
Mean: 16
Stdev: 0 (0.0%)
Runs: 16 16 16 16 16 16 16 16 16 16

Current
Mean: 16
Stdev: 0 (0.0%)
Runs: 16 16 16 16 16 16 16 16 16 16
Performance test for EndedBookings page Baseline
Mean: 24.0 ms
Stdev: 1.4 ms (5.9%)
Runs: 26 25 25 25 24 24 24 23 23 21

Current
Mean: 22.7 ms
Stdev: 2.1 ms (9.3%)
Runs: 25 25 25 24 24 22 21 21 20 20
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 86.6 ms
Stdev: 2.7 ms (3.1%)
Runs: 91 89 88 88 88 86 86 84 83 83

Current
Mean: 85.0 ms
Stdev: 3.2 ms (3.8%)
Runs: 89 87 87 87 87 86 85 82 80 80
Baseline
Mean: 10
Stdev: 0 (0.0%)
Runs: 10 10 10 10 10 10 10 10 10 10

Current
Mean: 10
Stdev: 0 (0.0%)
Runs: 10 10 10 10 10 10 10 10 10 10
Performance test for Profile page Baseline
Mean: 97.8 ms
Stdev: 3.4 ms (3.4%)
Runs: 102 101 101 99 99 98 96 96 95 91

Current
Mean: 96.1 ms
Stdev: 2.8 ms (2.9%)
Runs: 100 100 99 96 96 95 95 95 93 92
Baseline
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8

Current
Mean: 8
Stdev: 0 (0.0%)
Runs: 8 8 8 8 8 8 8 8 8 8
Performance test for Offer page Baseline
Mean: 520.2 ms
Stdev: 8.3 ms (1.6%)
Runs: 539 524 522 522 521 521 519 513 512 509

Current
Mean: 518.5 ms
Stdev: 13.5 ms (2.6%)
Runs: 545 533 528 519 518 514 513 508 507 500
Baseline
Mean: 14
Stdev: 0 (0.0%)
Runs: 14 14 14 14 14 14 14 14 14 14

Current
Mean: 14
Stdev: 0 (0.0%)
Runs: 14 14 14 14 14 14 14 14 14 14
Performance test for Favorites page Baseline
Mean: 111.6 ms
Stdev: 4.9 ms (4.4%)
Runs: 119 116 116 116 111 111 109 107 106 105

Current
Mean: 109.5 ms
Stdev: 3.3 ms (3.1%)
Runs: 117 112 111 110 109 109 108 107 107 105
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against b52ec16

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kopax-polyconseil kopax-polyconseil merged commit 57baa76 into master Nov 6, 2023
40 checks passed
@kopax-polyconseil kopax-polyconseil deleted the bsr-update-axe-storybook-testing branch November 6, 2023 16:57
marineshaw added a commit that referenced this pull request Nov 7, 2023
…-testing from 7.1.1 to 7.1.2 (#5550)"

This reverts commit 57baa76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants