getMultipleItems function added! (issue #108) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emstoppel
reviewed
Apr 24, 2021
| @@ -135,6 +135,17 @@ func (c *cache) Get(k string) (interface{}, bool) { | |||
| return item.Object, true | |||
| } | |||
|
|
|||
| //GetMultipleItems returns an array of items corresponding to the input array | |||
| func (c *cache) GetMultipleItems(values []string) []interface{} { | |||
There was a problem hiding this comment.
should it really be called GetMultipleItems, it is a bit stuttery to me, look that the Get function is not called GetItem
emstoppel
reviewed
Apr 24, 2021
| //GetMultipleItems returns an array of items corresponding to the input array | ||
| func (c *cache) GetMultipleItems(values []string) []interface{} { | ||
| length := len(values) | ||
| var items = make([]interface{}, length) |
There was a problem hiding this comment.
i would consider if the length of values is 0 an inmediate return, we could be initializing a 0 length map otherwise
Repository owner
deleted a comment from
pablodz
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #108