feat(alert): add pf-alert #2593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 472fa59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
work in progress
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
… feat/add-pf-alert
….Add function to SlotController
bennypowers
requested changes
Oct 8, 2023
bennypowers
requested changes
Oct 8, 2023
| const hasContent = this.#slots.hasAnonymousSlot(); | ||
|
|
||
| return html` | ||
| <div id="container" role="alert" aria-hidden="false" class="${classMap({ truncateTitle })}"> |
There was a problem hiding this comment.
can a role=alert have interactive children @nikkimk?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Alert_Role
…nfly-elements into feat/add-pf-alert
Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
…nfly-elements into feat/add-pf-alert
bennypowers
requested changes
Oct 15, 2023
Comment on lines
1
to
2
| <link rel="stylesheet" href="demo.css"> | ||
| <script type="module" src="pf-alert.js"></script> |
There was a problem hiding this comment.
let's prefer to inline this stuff, to make the demos easier to grok
elements/pf-alert/demo/inline.html
Outdated
Comment on lines
1
to
2
| <link rel="stylesheet" href="demo.css"> | ||
| <script type="module" src="pf-alert.js"></script> |
elements/pf-alert/demo/inline.html
Outdated
Comment on lines
4
to
7
| <h1> | ||
| Inline | ||
| </h1> | ||
|
|
There was a problem hiding this comment.
Suggested change
| <h1> | |
| Inline | |
| </h1> |
elements/pf-alert/demo/inline.html
Outdated
Comment on lines
14
to
17
| <h1> | ||
| Inline Plain | ||
| </h1> | ||
|
|
There was a problem hiding this comment.
Suggested change
| <h1> | |
| Inline Plain | |
| </h1> | |
| <h2>Plain</h2> | |
Comment on lines
1
to
2
| <link rel="stylesheet" href="demo.css"> | ||
| <script type="module" src="pf-alert.js"></script> |
elements/pf-alert/demo/pf-alert.html
Outdated
Comment on lines
5
to
8
| <pf-alert variant="info" header="Info alert title"></pf-alert> | ||
| <pf-alert variant="success" header="Success alert title"></pf-alert> | ||
| <pf-alert variant="warning" header="Warning alert title"></pf-alert> | ||
| <pf-alert variant="danger" header="Danger alert title"></pf-alert> |
There was a problem hiding this comment.
Suggested change
| <pf-alert variant="info" header="Info alert title"></pf-alert> | |
| <pf-alert variant="success" header="Success alert title"></pf-alert> | |
| <pf-alert variant="warning" header="Warning alert title"></pf-alert> | |
| <pf-alert variant="danger" header="Danger alert title"></pf-alert> |
we can leave these for variants.html
elements/pf-alert/demo/plain.html
Outdated
Comment on lines
1
to
2
| <link rel="stylesheet" href="demo.css"> | ||
| <script type="module" src="pf-alert.js"></script> |
elements/pf-alert/pf-alert.css
Outdated
| --pf-alert-title-color: var(--pf-alert-title-color, var(--pf-global--default-color--300, #003737)); | ||
| --pf-alert-icon-color: var(--pf-alert-icon-color, var(--pf-global--default-color--200, #009596)); | ||
| --pf-alert-inline-background-color: var(--pf-global--palette--cyan-50, #f2f9f9); | ||
| --alert-title-color: var(--alert-title-color, var(--pf-global--default-color--300, #003737)); |
There was a problem hiding this comment.
Suggested change
| --alert-title-color: var(--alert-title-color, var(--pf-global--default-color--300, #003737)); | |
| --_alert-title-color: var(--pf-global--default-color--300, #003737); |
etc, and at call sites
| danger: { set: 'fas', icon: 'exclamation-circle' }, | ||
| info: { set: 'fas', icon: 'info-circle' }, | ||
| close: { set: 'patternfly', icon: 'close' }, | ||
| get(name: 'default' | 'success' | 'warning' | 'danger' | 'info' | 'close') { |
There was a problem hiding this comment.
remove get() and reference the data here in render
elements/pf-alert/pf-alert.ts
Outdated
| const hasActions = this.#slots.hasSlotted('actions'); | ||
| const hasDescriptionContent = this.#slots.hasSlotted(); | ||
|
|
||
| return html` | ||
| <div id="container" role="alert" aria-hidden="false" class="${classMap({ truncateTitle })}"> | ||
| <div id="left-column" part="left-column"> | ||
| <slot name="icon" id="icon">${icon}</slot> | ||
| <slot name="icon" id="icon">${this.#icon}</slot> |
There was a problem hiding this comment.
inline the pf-icon, reference data in ICONS directly here. remove #icon
bennypowers
reviewed
Oct 16, 2023
| @@ -1,5 +1,4 @@ | |||
| <link rel="stylesheet" href="demo.css"> | |||
| <script type="module" src="pf-alert.js"></script> | |||
| <link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | |||
There was a problem hiding this comment.
For the sake of clarity, What I mean by inline is to replace <link href with <style and <script src with <script
In other words, each demo file would be self contained except for the files we ship in our package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2539
What I did
Testing Instructions
Notes to Reviewers