-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icon)!: remove BaseIcon #2636
base: staging/4.0
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d462f0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,4 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
--- |
Ignore suggestion, blocking comment for approval.
Don't merge until non-breaking changes are released in 2.5.0
Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com>
Closes #2621
What I did
Testing Instructions
Notes to Reviewers