Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global vars - remove selector prop, show selector column #3886

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from

Conversation

evwilkin
Copy link
Contributor

@evwilkin evwilkin commented Feb 12, 2024

Towards #3551

Note: please leave any suggestions for additional enhancements/changes, I wasn't clear if this was all we need currently.

This PR:

  • Bumps versions to latest alphas
  • Removes the selector prop used in global-css-variables.md that was filtering to only show rules matching selector :where(:root)
    • it now shows all vars, but we could add in new selector :root to only show new vars (or leave as-is showing everything and wait until core cleanup?)
  • Unhides the "selector" column from the global vars table
    • though all the new vars map to the :root selector, this column enables rows to be expanded (where applicable) to track the variable chain.
    • Screenshot 2024-02-12 at 6 47 03 PM

@patternfly-build
Copy link
Contributor

@nicolethoen
Copy link
Collaborator

This is similar to what I built into the design token docs. I think the biggest difference (other than a few visual differences) is that building it from the design-tokens repo means that they are up to date with the latest in the tokens repo - rather than reading design tokens as passed from design-tokens -> core -> react -> org (which will always be a few steps behind).

@nicolethoen
Copy link
Collaborator

I was also planning to have the token docs page go in the new 'tokens' subnav item that Erin was building.

@evwilkin
Copy link
Contributor Author

@nicolethoen that all makes sense and sounds great to me, would you suggest I close this PR out in favor of the momentum you have going in your related issues?

@nicolethoen
Copy link
Collaborator

It's possible? Though I hadn't even thought of how the Global CSS vars might be the same or almost the same as the design tokens once all is said and done. It also may be worth a conversation to see what we should do with this page on the v6 site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants