Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(get-started): Updates "about PatternFly" page. #3930

Merged
merged 27 commits into from
May 29, 2024

Conversation

edonehoo
Copy link
Collaborator

Closes #3897

@edonehoo edonehoo changed the base branch from main to v6 March 22, 2024 13:36
@edonehoo edonehoo self-assigned this Mar 22, 2024
@edonehoo
Copy link
Collaborator Author

edonehoo commented Mar 22, 2024

bunch of notes/q's:

  • merged the "community" page into the main "about patternfly" page, which aligns with some of the feedback from our user research. does it work? is too much lost/cut out in this move?
  • I POC'd a bunch of cards (which are looking funky right now) to try and present info differently
    • as part of this ^ I kind of organized the major parts of PF into "categories", which I'm curious for thoughts on. Does the grouping make sense? The naming? Another research result is that we should consider grouping the left nav into sections, which (if we go forward with that) I'd like to match the organization in this page, so want to be sure it makes sense
  • Longer term, this page would benefit from more images (per user feedback), but not sure where to start with that. Maybe we could make the cards a split design of some kind idk. Sounds like followup if there's bandwidth

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 22, 2024

Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits.

@srambach
Copy link
Member

I like the cards. I'm a little confused by the about.md and about-PatternFly.md both? They seem to be the same or very similar?
Also I do feel like some things were cut that are important - like release cadence and beta features?

@edonehoo
Copy link
Collaborator Author

@srambach ty for the feedback!!

  1. I added about-patternfly.md to replace about.md, since the page name changed to "about patternfly". Meant to delete about.md! Just did that, but lmk if you see any issues

  2. Release cadence:

  • I repurposed some of this info under "how do I stay up to date", but maybe that heading isn't very clear? I swapped back to "release cadence". I also added back the info I left off regarding "React next".
  • I think, long term, the React next info could be moved (I'll mention this below)
  1. Beta components:
  • I did remove this info, but I just added it back for now!
  • I also think that this info could move somewhere better in the future (below)

I've talked to Andrew about this idea some, but I think there's a good opportunity to create an "all components" kind of doc on org (as proposed in patternfly/patternfly-design#1301). This would be a place where we could add higher level component docs (like information about beta components and deprecated components) so that they're more and juxtaposed by the component docs. I think numbers 2 and 3 above could both be moved into that new area, if/when it does come to fruition. But, if they need to be moved in the future, that can be handled in a separate pr!

<Grid sm={12} md={4} hasGutter>
<Button size="lg" variant="secondary" component="a" href="/get-started/design"> Start designing </Button>
<Button size="lg" variant="secondary" component="a" href="/get-started/develop"> Start developing </Button>
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute/contributing-to-patternfly"> Contribute to PatternFly</Button>
Copy link
Collaborator Author

@edonehoo edonehoo May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute/contributing-to-patternfly"> Contribute to PatternFly</Button>
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute"> Contribute to PatternFly</Button>

Note to change this if #3926 closes. Could be handled in a followup issue that updates links across the website, assuming there's a few areas that would need this change

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments/questions, but nothing major.

</CardFooter>
</Card>
<Card isCompact>
<CardTitle className="pf-v5-u-font-size-l"> Follow us on Twitter </CardTitle>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be X now? 🙄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yes, good catch! It's still Twitter in my head 😅

Actually, since there are a few places across the site that mention Twitter, I'll also open a separate issue to update everywhere else. Going ahead and changing it here, though!


## Release cadence

We plan to release a new major version of PatternFly every year. These major releases will be the only releases with planned "breaking" changes that alter core code functionality. Along with each major release, we will provide detailed upgrade guides and codemods to support the work needed to upgrade your products to the latest version of PatternFly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"breaking" changes that alter core code functionality - since we use "core" as the css repo, should this be something like "breaking changes" that alter the way your code interacts with the PatternFly code or something like that? Or say PatternFly's API but it's not an API like some may define it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great point! I like that suggestion


Occasionally, after a component is promoted out of beta, subsequent enhancement requests require the introduction of new CSS class names and React properties. Whenever these enhancements are substantial enough to lead to further component updates (pending testing and feedback), then a beta label is applied to the new class names and properties, as well as relevant examples in the component’s documentation.

[Learn more about beta components and view a list of current promotion candidates here.](https://github.com/patternfly/patternfly-org/tree/main/beta-component-promotion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy, the content at this link could use some updating! 😄

<Grid sm={12} md={4} hasGutter>
<Button size="lg" variant="secondary" component="a" href="/get-started/design"> Start designing </Button>
<Button size="lg" variant="secondary" component="a" href="/get-started/develop"> Start developing </Button>
<Button size="lg" variant="secondary" component="a" href="/get-started/contribute"> Contribute to PatternFly</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link seems to be broken. I think it's this one get-started/contribute/contributing-to-patternfly

Copy link
Collaborator Author

@edonehoo edonehoo May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm so this pr, which will probably be merged at the same time as this one, changes the url to be /get-started/contribute. Do you think I should keep the link as get-started/contribute/contributing-to-patternfly in this pr and just do a follow up once these are all merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge them all! lol

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Changes look good!

wise-king-sullyman and others added 3 commits May 23, 2024 14:14
 - @patternfly/ast-helpers@1.4.0-alpha.21
 - @patternfly/documentation-framework@6.0.0-alpha.32
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet moves!

@jessiehuff jessiehuff merged commit 2db13a7 into patternfly:v6 May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update "about PatternFly" get started page.
6 participants