Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comparison table to table guidelines #4006

Merged
merged 3 commits into from
May 9, 2024

Conversation

mmenestr
Copy link
Collaborator

@mmenestr mmenestr commented May 6, 2024

@patternfly-build
Copy link
Contributor

patternfly-build commented May 6, 2024

@jpuzz0 jpuzz0 self-requested a review May 7, 2024 17:36
jpuzz0
jpuzz0 previously approved these changes May 7, 2024
edonehoo
edonehoo previously approved these changes May 8, 2024
Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, but otherwise looks good!

@@ -118,6 +118,32 @@ The actionable table provides checkboxes or radio buttons that enable users to s
#### When not to use
* Users can not take any actions on table items/rows.

### Comparison table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add this as a list item on line 77?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!! Just updated

@mmenestr mmenestr dismissed stale reviews from edonehoo and jpuzz0 via fac2f8c May 9, 2024 13:27
Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘❗️

@jessiehuff jessiehuff merged commit 1f4cd62 into patternfly:main May 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comparison table design guidelines
5 participants