chore(docs): fix page-loaded class #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoker
previously approved these changes
May 9, 2024
There was a problem hiding this comment.
LGTM! I did pull it down and test with a big image on an example and the event is firing before the image has fully loaded, but I also added this to the <head> and as the last thing in <body> and got the same results, so I think the change in this PR is good, though we'll have to see if we still have any issues with images loading
<script>
window.onload = function() {
console.log("window.load fired");
};
</script>
wise-king-sullyman
previously approved these changes
May 10, 2024
mcoker
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4009
This PR adds extra logic to check if page has already finished loading (and if so, adds the page-loaded class) before adding window.load event listener.