-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataLis pagination demo #10276
base: main
Are you sure you want to change the base?
DataLis pagination demo #10276
Conversation
Preview: https://patternfly-react-pr-10276.surge.sh A11y report: https://patternfly-react-pr-10276-a11y.surge.sh |
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get a basic pagination working, and more than 10 items to see it (created with a loop so all the code isn't just for the items themselves).
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
implement review comments
Thanks you all for reviewing PR. In Github issue, it was about the static pagination. That's why I made it static pagination, not dynamic. |
i understand the confusion there, HTML demos are always static in that sense necessarily though. |
packages/react-core/src/demos/DataList/examples/DataListPagination.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments below, not really blockers though.
Hey folks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
What: Closes #10247
DataList pagination demo
Additional issues: