-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(table): table selectors #5558
Conversation
Preview: https://patternfly-pr-5558.surge.sh A11y report: https://patternfly-pr-5558-a11y.surge.sh |
1fbe292
to
3a227a9
Compare
@mcoker @srambach Wdyt about this approach to table style versioning without changing specificity? What this PR does
|
396684c
to
5af6426
Compare
8241072
to
01815c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good afaict 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good! Lots of little bugs, most have created visual discrepancies (how I found them), but all CSS and can be cleaned up later except for the table grid one. Depending on what you want to do there, that might require markup changes. Lemme know if I can help.
Also... can we still run screenshot tests? I think I found all the issues, but this would be a great case for screenshot comparisons to find issues.
And this one is not tied to a prefixed class, but I didn't see the change in the changeset, so leaving it here -
tr.pf-m-striped { // tr |
should probably be
tr:where(.#{$table}__tr).pf-m-striped { // tr
01815c9
to
77a0a58
Compare
a458ecf
to
a6687fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
🎉 This PR is included in version 5.0.0-alpha.55 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #5549
What this PR does
.#{$table}__tr
,.#{$table}__th
, and.#{$table}__td
selectors..#{$table} > thead
combinator to elements without an applied class (tbody
,thead
,*
):where()
:pseudo to retain specificity while adding versioned class totr
,th
, andtd
tbody
andthead
are ignored in this class update in that they can be targeted with a direct child pseudo.tr
is updated as adding a I sawtr:where(.#{$table}__tr
to be preferable over:where(.#{$table}) > tbody > tr