feat(global): dark theme versioning #5598
Merged
+57
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnolting
force-pushed
the
feat-dark-theme-versioning
branch
from
a600926 to
1031dc2
Compare
|
Preview: https://patternfly-pr-5598.surge.sh A11y report: https://patternfly-pr-5598-a11y.surge.sh |
mattnolting
force-pushed
the
feat-dark-theme-versioning
branch
2 times, most recently
from
3c433a2 to
fc0c7dd
Compare
mcoker
approved these changes
May 18, 2023
There was a problem hiding this comment.
What you have here works, but I think you may have referenced the wrong sass var for the placeholder classes? If what you have in the PR is on purpose, I think it's OK to merge as is, but we're using .pf-theme-dark for .pf-t-dark, and those have different roles. Left a couple of code suggestions for what I saw there.
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mattnolting
force-pushed
the
feat-dark-theme-versioning
branch
from
bac39ee to
13e2fdc
Compare
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mattnolting
force-pushed
the
feat-dark-theme-versioning
branch
from
0148eb9 to
cd38c2e
Compare
mcoker
approved these changes
May 25, 2023
mcoker
changed the title
|
🎉 This PR is included in version 5.0.0-alpha.65 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
added a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5567